bpo-35445: Do not ignore memory errors when create posix.environ.#11049
Merged
serhiy-storchaka merged 1 commit intopython:masterfrom Dec 10, 2018
Merged
Conversation
ZackerySpytz
reviewed
Dec 9, 2018
| if (PyDict_SetItem(d, k, v) != 0) | ||
| PyErr_Clear(); | ||
| if (PyDict_GetItemWithError(d, k) == NULL) { | ||
| if (PyErr_Occurred() || PyDict_SetItem(d, k, v) != 0) { |
Contributor
There was a problem hiding this comment.
These two ifs could be merged.
Member
Author
There was a problem hiding this comment.
Yes, but the resulting condition will be too complex and will need more parentheses and line breaks in any case. I do not think it will look better.
if ((PyDict_GetItemWithError(d, k) == NULL) &&
(PyErr_Occurred() || PyDict_SetItem(d, k, v) != 0))
{
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35445